Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collection in collection support #28

Merged
merged 6 commits into from
Aug 16, 2023
Merged

Collection in collection support #28

merged 6 commits into from
Aug 16, 2023

Conversation

ystrict
Copy link
Contributor

@ystrict ystrict commented Jul 12, 2023

Added support for collection to contain collection

@ystrict ystrict mentioned this pull request Jul 12, 2023
Open
vierbergenlars
vierbergenlars reviewed Jul 14, 2023
View reviewed changes
Copy link
Member

@vierbergenlars vierbergenlars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we missed some issue regarding the type being used in array and set terms in your previous PR

rego-java/src/main/java/com/contentgrid/opa/rego/ast/Term.java Outdated Show resolved Hide resolved
rego-java/src/main/java/com/contentgrid/opa/rego/ast/Term.java Outdated Show resolved Hide resolved
rego-java/src/main/java/com/contentgrid/opa/rego/ast/Term.java Outdated Show resolved Hide resolved
@ystrict
Copy link
Contributor Author

ystrict commented Aug 14, 2023

Looks like we missed some issue regarding the type being used in array and set terms in your previous PR

Fixed, please take a look

@vierbergenlars vierbergenlars merged commit 6b9132f into xenit-eu:main Aug 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vierbergenlars vierbergenlars vierbergenlars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ystrict @vierbergenlars